Repository navigation
chore(deps-dev): bump cpp-linter from 1.14.1 to 1.15.1 in the org group across 1 directory - #501
dependabot[bot] wants to merge 1 commit into
Conversation
Cpp-Linter Report
|
|
We should probably run this branch through the test repo. |
|
I agree |
7319830 to
53a13e5
Compare
|
Ran this branch through the test repo (temporary PR cpp-linter/test-cpp-linter-action#64, now closed), next to a baseline of Works the same as 1.14.1 on ubuntu-latest, ubuntu-24.04-arm, macos-latest and windows-latest:
Runs: https://github.com/cpp-linter/test-cpp-linter-action/actions/runs/38806552518 (pull_request), https://github.com/cpp-linter/test-cpp-linter-action/actions/runs/38806544496 (push) Not caused by this PR:
Found since, and the reason to hold this PR:
Suggest keeping this open until a 1.15.x release fixes the GHES URL. |
This should not be happening. I'll review the code in git-bot-feedback. It should automatically detect the marker is present before prepending it. Maybe that check was only applied to thread-comments.
Needs to be raised in git-bot-feedback repo.
Yes and no. Depends on what exactly was observed. git-bot-feedback will still traverse ignore paths in case there is an unignored rule for a nested file/folder. Technically speaking, I think it is wrong if v1.14 ignored Ultimately, there should be no files reported from /src/build (to borrow your example) if the |
I looked into this more. First, I could not find evidence of this problem in the linked CI runs. Secondly, I think you stumbled upon a bug in v1.14. An I guess switching to git-bot-feedback abstracted (and fixed) that problem in v1.15. 🎉 I raised issues for the other 2 findings.
Believe it or not, I'm the reason pygit2 now builds windows wheels with cibuildwheels in their CI. But when trying to add windows-arm64 builds, the build env needed too much special attention to feasibly create win-arm64 wheels. Maybe that's changed since the arm containers migrated to GH-controlled repo... IDK. We could instead just remove pygit2 and switch to |
Follow-up to #140. Before: GraphQL requests used `api_url.join("/graphql")`. The leading `/` replaces the whole path, so on GitHub Enterprise Server, where the REST API is at `https://<host>/api/v3` and GraphQL is at `https://<host>/api/graphql`, every GraphQL request (fetching existing review threads, resolving or deleting old review comments, hiding outdated reviews) went to `https://<host>/graphql` and failed. After: the client reads the GraphQL endpoint from `GITHUB_GRAPHQL_URL`, which GitHub runners set on both github.com (`https://api.github.com/graphql`) and GHES (`https://<host>/api/graphql`). When it is not set, it falls back to `https://api.github.com/graphql`, the same way `GITHUB_API_URL` falls back to `https://api.github.com`. | Runner | GraphQL URL before | GraphQL URL after | | --- | --- | --- | | github.com | `https://api.github.com/graphql` | `https://api.github.com/graphql` (unchanged) | | GHES | `https://<host>/graphql` | `https://<host>/api/graphql` | How: `GithubApiClient` stores the parsed `GITHUB_GRAPHQL_URL` in a `graphql_url` field, used by all three GraphQL calls in `graphql.rs`. The unit test `ensure_api_url_has_trailing_slash` checks the field, and `tests/github_pr_reviews.rs` points `GITHUB_GRAPHQL_URL` at the mock server. Found while testing cpp-linter-action with cpp-linter 1.15.0 (cpp-linter/cpp-linter-action#501). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved GitHub integration when retrieving, closing, or hiding outdated review comments. * Added support for correctly connecting to GraphQL endpoints across GitHub.com, GitHub Enterprise, and local server configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This pulls in fixes for bugs found and reported upstream in cpp-linter/cpp-linter-action#501 See also [GBF bindings/python/CHANGELOG](https://github.com/2bndy5/git-bot-feedback/blob/main/bindings/python/CHANGELOG.md)
This pulls in fixes for bugs found and reported upstream in cpp-linter/cpp-linter-action#501 See also [GBF bindings/python/CHANGELOG](https://github.com/2bndy5/git-bot-feedback/blob/main/bindings/python/CHANGELOG.md) Co-authored-by: Xianpeng Shen <xianpeng.shen@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This pulls in some fixes for bugs reported via python integration in cpp-linter/cpp-linter-action#501 See [GBF CHANGELOG.md](https://github.com/2bndy5/git-bot-feedback/blob/main/CHANGELOG.md) for more detail. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit - **Bug Fixes** - Improved reliability of automated code review feedback integrations. - **Tests** - Updated integration test configuration to better validate GraphQL-based feedback workflows. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
@dependabot recreate |
Bumps the org group with 1 update in the / directory: [cpp-linter](https://github.com/cpp-linter/cpp-linter). Updates `cpp-linter` from 1.14.1 to 1.15.1 - [Release notes](https://github.com/cpp-linter/cpp-linter/releases) - [Commits](cpp-linter/cpp-linter@v1.14.1...v1.15.1) --- updated-dependencies: - dependency-name: cpp-linter dependency-version: 1.15.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: org ... Signed-off-by: dependabot[bot] <support@github.com>
ac143e0 to
da7f4c5
Compare
|
End-to-end test of this PR plus clang-tools 2.0.0: no regressions found. What was tested: cpp-linter-action at fc065f1 (this PR's head, cpp-linter 1.15.1, plus Same results as
clang-tools 2.0.0
On a pull request (PR run)
Two notes for the release notes, both from cpp-linter 1.15.x:
Generated by Claude Code |
|
@dependabot recreate |
|
Looks like cpp-linter is updatable in another way, so this is no longer needed. |
Bumps the org group with 1 update in the / directory: cpp-linter.
Updates
cpp-linterfrom 1.14.1 to 1.15.1Release notes
Sourced from cpp-linter's releases.
... (truncated)
Commits
0df0602fix: support a--repo-rootin a sub-folder of the git repo (#247)8f369e7test: cover missing-token exits and 404 responses, keep tests off real GitHub...55cf791fix: stop changing into--repo-rootand only accept one inside the working ...2a37247build(deps): bump certifi from 2025.10.5 to 2026.10.19 (#244)d08ee70chore(dev): test against Python 3.15 and the 3.16 pre-release (#241)188e1fdchore: count only binary downloads in funding.json (#243)79c3660fix: raise when git cannot read the original file (#242)db00cfbbuild: bump git-bot-feedback from 0.2.6 to 0.2.9 (#239)0619384fix: replace pygit2 with agit diffsubprocess (#240)a5bc7dbdocs: fix outdated CI note, docs build steps and CLI doc generation (#238)